Skip to content

Conversation

@samgst-amazon
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samgst-amazon samgst-amazon changed the base branch from main to feature/q-lsp-chat April 24, 2025 00:03
@samgst-amazon samgst-amazon marked this pull request as ready for review April 24, 2025 00:21
@samgst-amazon samgst-amazon requested review from a team as code owners April 24, 2025 00:21
@samgst-amazon
Copy link
Contributor Author

This is needed to unblock chat responses but needs a lot more work

@github-actions
Copy link

github-actions bot commented Apr 24, 2025

Qodana Community for JVM

17 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 17

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

companion object {
private val stringToEnum: Map<String, IconType> = entries.associateBy { it.name.lowercase() }

fun fromString(value: String): IconType = stringToEnum[value] ?: throw IllegalArgumentException("Unknown IconType: $value")

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Function "fromString" is never used
}

enum class Status {
INFO,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "INFO" is never used

enum class Status {
INFO,
SUCCESS,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "SUCCESS" is never used
enum class Status {
INFO,
SUCCESS,
WARNING,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "WARNING" is never used
INFO,
SUCCESS,
WARNING,
ERROR,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "ERROR" is never used

enum class MessageType {
ANSWER,
PROMPT,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "PROMPT" is never used
enum class MessageType {
ANSWER,
PROMPT,
SYSTEM_PROMPT,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "SYSTEM_PROMPT" is never used
ANSWER,
PROMPT,
SYSTEM_PROMPT,
DIRECTIVE,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "DIRECTIVE" is never used
PROMPT,
SYSTEM_PROMPT,
DIRECTIVE,
TOOL,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "TOOL" is never used
const val CHAT_TAB_ADD = "aws/chat/tabAdd"
const val CHAT_TAB_CHANGE = "aws/chat/tabChange"
const val CHAT_TAB_REMOVE = "aws/chat/tabRemove"
const val CHAT_OPEN_TAB = "aws/chat/openTab"

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "CHAT_OPEN_TAB" is never used
@samgst-amazon samgst-amazon merged commit c78e99c into feature/q-lsp-chat Apr 24, 2025
3 of 9 checks passed
@samgst-amazon samgst-amazon deleted the samgst/q-lsp-chat-openTab branch April 24, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants